Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(www): add notes on how to compose multiple dialogs with menus #4969

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ChristianIvicevic
Copy link

@ChristianIvicevic ChristianIvicevic commented Sep 26, 2024

The proposed solution I have added is pretty much buried in a linked conversation and it took me some time to find it myself for the same problem I ran into. As such, I decided to contribute this to the docs.

As this is my first time contributing to this repository I wasn't sure about code conventions when writing docs so I'm looking forward to get this reviewed.

Copy link

vercel bot commented Sep 26, 2024

@ChristianIvicevic is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@ChristianIvicevic ChristianIvicevic changed the title docs(www): add notes on how composing multiple dialogs with menus docs(www): add notes on how to compose multiple dialogs with menus Sep 26, 2024
@ChristianIvicevic ChristianIvicevic force-pushed the contextmenu-dialog-composition branch 2 times, most recently from 1586142 to 344d356 Compare September 26, 2024 07:36
Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview Sep 26, 2024 0:00am

@ChristianIvicevic
Copy link
Author

I just pushed a small change compared to the previous version to make the hook more type-safe by passing ElementRef<typeof DropdownMenuItem> rather than a HTMLDivElement to it in order to demo a realistic use of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant