Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removing unwanted CommandDialogProps in command.tsx #4911

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Prathamesh-chougale-17
Copy link

@Prathamesh-chougale-17 Prathamesh-chougale-17 commented Sep 20, 2024

Screenshot 2024-09-20 101738

Above was the eslint error found due to unnecessary use of CommandDialogProps at command.tsx. So I removed it and set the DialogProps Directly.

Screenshot 2024-09-20 101937

There was Type-error at CommandDialogProps : An interface declaring no members is equivalent to its supertype

Resolved above error

Removed unnecessary CommandDialogProps and replaced with type DialogProps to the function CommandDialog props
Copy link

vercel bot commented Sep 20, 2024

@Prathamesh-chougale-17 is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@Prathamesh-chougale-17 Prathamesh-chougale-17 changed the title fix: Fixed the type error at CommandDialogProps fix: Fixed the type error at CommandDialogProps in command.tsx Sep 20, 2024
@Prathamesh-chougale-17 Prathamesh-chougale-17 changed the title fix: Fixed the type error at CommandDialogProps in command.tsx fix: removing unwanted CommandDialogProps in command.tsx Sep 20, 2024
@Prathamesh-chougale-17 Prathamesh-chougale-17 changed the title fix: removing unwanted CommandDialogProps in command.tsx fix: Removing unwanted CommandDialogProps in command.tsx Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant