Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add math eval to CI nightly run #2663

Conversation

XiaotongJiang
Copy link
Contributor

@XiaotongJiang XiaotongJiang commented Dec 30, 2024

Fix forward for #2652

How did i test:

  • tested by temp moving the nightly test suites to per-commit

@XiaotongJiang
Copy link
Contributor Author

took a look of the recent flaky nightly tests, theres some flakiness around gsm8k threshold for certain models, but the main contributor is human eval timing out from evalplus.evaluate, it seems they are using sync client in strict sequential manner link and its slow. I didnt see a good way to speed it up, should we swap to other human eval lib? @Ying1123 @zhaochenyang20

@zhaochenyang20
Copy link
Collaborator

took a look of the recent flaky nightly tests, theres some flakiness around gsm8k threshold for certain models, but the main contributor is human eval timing out from evalplus.evaluate, it seems they are using sync client in strict sequential manner link and its slow. I didnt see a good way to speed it up, should we swap to other human eval lib? @Ying1123 @zhaochenyang20

As we discussed, use is_in_ci to detect wether it's in the CI and only run default_samll_model_name on human eval.

Thanks, great job!

@zhaochenyang20 zhaochenyang20 enabled auto-merge (squash) January 1, 2025 18:34
Copy link
Collaborator

@zhaochenyang20 zhaochenyang20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why disable human eval rather than add more time out?

@zhaochenyang20
Copy link
Collaborator

@XiaotongJiang LGTM

@zhaochenyang20 zhaochenyang20 merged commit a4d6d6f into sgl-project:main Jan 1, 2025
14 checks passed
XiaotongJiang added a commit to XiaotongJiang/sglang that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants