- 
                Notifications
    
You must be signed in to change notification settings  - Fork 3.3k
 
Allow larger max num dispatch tokens per rank for DeepEP #11168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
          Summary of ChangesHello @fzyzcjy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the DeepEP token dispatcher by allowing a greater number of tokens to be dispatched per rank. The modification updates an internal assertion limit and a related comment, reflecting an increased capacity for token handling within the distributed system. This change is crucial for supporting larger model operations and ensuring compatibility with recent DeepEP project developments. Highlights
 Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either  
 Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a  Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the maximum number of dispatch tokens per rank for DeepEP from 1024 to 2048, aligning with an upstream change in the DeepEP library. My review focuses on improving the code's maintainability by refactoring the newly introduced magic number.
Motivation
can only merge after deepseek-ai/DeepEP#440 is merged
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist