More CLI hardening #120
Merged
More CLI hardening #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has a number of problems and better not to try and fix them in a hurry pre shipping. See sgkit-dev#121 and sgkit-dev#122
|
I think this can Close #101 now This should be mostly uncontroversial @tomwhite except for removing the sample subsetting code. I think that needs another pass at implementation and a lot more testing, which I don't have time to do right now, so I think it's best to drop temporarily so we can ship a release. What do you think? |
|
@jeromekelleher I think that's OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.