Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI for Zarr Python v3 #1285

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Fix CI for Zarr Python v3 #1285

merged 3 commits into from
Jan 14, 2025

Conversation

tomwhite
Copy link
Collaborator

@tomwhite tomwhite commented Jan 14, 2025 •
edited
Loading

@tomwhite tomwhite marked this pull request as ready for review January 14, 2025 13:02
@tomwhite
Copy link
Collaborator Author

This is ready to go in - it fixes the build so it works with both Zarr Python v2 and v3. I had to update to use the latest version of bio2zarr from github, rather than a released version, but that's probably OK since it's being updated quite a lot (we do the same in vcztools).

(Cubed tests are still failing, but I will tackle those in another PR, see #1284.)

@tomwhite tomwhite merged commit 34ba02c into sgkit-dev:main Jan 14, 2025
9 of 10 checks passed
@tomwhite tomwhite deleted the fix-zarr-python-v3-ci branch January 14, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromekelleher jeromekelleher jeromekelleher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix CI for Zarr Python v3
2 participants
@tomwhite @jeromekelleher