Fix TypeScript signature of the emscripten module init function #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for stupefied-edison-1dae54 canceled.
|
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
This function is generated automatically with opencascadejs - so your commit will be overridden the next time I generate them. I should update the version I use to generate the bindings (and it should solve it). |
sgenoud
force-pushed
the
main
branch
4 times, most recently
from
8d86723
to
8ba3d25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes TypeScript problem described in issue #54.
The pach adds the missing argument to the init function. For simplicity, the type of the argument is set to
any. Exact type could be imported from @types/emscripten. However, introducing new dependency is a serious thing, so I leave the decision to the maintainers of this awesome package.