Merge branch 'main' into image_compression

sgenoud · May 5, 2023 · 99dd2a4 · 99dd2a4
2 parents 72a3cfb + cb16e3c
commit 99dd2a4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/.github/workflows/cla.yml b/.github/workflows/cla.yml
@@ -5,14 +5,19 @@ on:
   pull_request_target:
     types: [opened,closed,synchronize]
 
+permissions:
+  actions: write
+  contents: write
+  pull-requests: write
+  statuses: write
+
 jobs:
   CLAssistant:
     runs-on: ubuntu-latest
     steps:
       - name: "CLA Assistant"
         if: (github.event.comment.body == 'recheck' || github.event.comment.body == 'I have read the CLA Document and I hereby sign the CLA') || github.event_name == 'pull_request_target'
-        # Beta Release
-        uses: cla-assistant/[email protected]
+        uses: cla-assistant/[email protected]
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           # the below token should have repo scope and must be manually added by you in the repository's secret

diff --git a/packages/replicad/src/lib2d/offset.ts b/packages/replicad/src/lib2d/offset.ts
@@ -97,7 +97,8 @@ export const make2dOffset = (
 
   // We need a better way to handle curves that self intersect, for now we
   // replace them with a line
-  if (selfIntersections(approximation).length) {
+  const selfIntersects = selfIntersections(approximation);
+  if (selfIntersects.length) {
     return {
       collapsed: true,
       firstPoint: approximation.firstPoint,