Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon to pkgdown site #553

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Add favicon to pkgdown site #553

merged 1 commit into from
Jun 23, 2023

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Jun 23, 2023

This will show the janitor logo on the webpage
image

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #553 (b7462b8) into main (4574e25) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #553   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         1179      1179           
=========================================
  Hits          1179      1179           

@sfirke
Copy link
Owner

sfirke commented Jun 23, 2023

Neat! Thank you @olivroy . This has been a busy last week for me so I haven't been able to respond to the other PRs but I have not forgotten about them.

@sfirke sfirke merged commit f4d7cb0 into sfirke:main Jun 23, 2023
@sfirke
Copy link
Owner

sfirke commented Jun 23, 2023

Hey it worked!

@olivroy olivroy deleted the favicon branch June 27, 2023 12:11
@olivroy olivroy mentioned this pull request Jun 27, 2023
9 tasks
@olivroy
Copy link
Contributor Author

olivroy commented Jun 27, 2023

No problem, I understand! Thanks for your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants