Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple rows input to row_to_names() #542

Merged
merged 15 commits into from
May 23, 2023
Merged

Allow multiple rows input to row_to_names() #542

merged 15 commits into from
May 23, 2023

Commits on Apr 13, 2023

  1. Remove condition limiting number of rows to names

    @matanhakim
    matanhakim committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    acee2ce View commit details
    Browse the repository at this point in the history

  2. Change 'row_to_names()' to accept multiple rows

    @matanhakim
    matanhakim committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    a1d106a View commit details
    Browse the repository at this point in the history

  3. Remove test for length-1 row number input

    @matanhakim
    matanhakim committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    87875af View commit details
    Browse the repository at this point in the history

  4. Restyle code operations for better readability

    @matanhakim
    matanhakim committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    f94e9a4 View commit details
    Browse the repository at this point in the history

  5. Replace NA's row names with empty strings

    @matanhakim
    matanhakim committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    64d8b00 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. Handle case of multiple NA name values

    @matanhakim
    matanhakim committed May 17, 2023
    Configuration menu
    Copy the full SHA
    7094666 View commit details
    Browse the repository at this point in the history

  2. Add sep argument and remove repeating or ending _

    @matanhakim
    matanhakim committed May 17, 2023
    Configuration menu
    Copy the full SHA
    27b6b0b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'sfirke:main' into main

    @matanhakim
    matanhakim committed May 17, 2023
    Configuration menu
    Copy the full SHA
    594e120 View commit details
    Browse the repository at this point in the history

  4. Update paste0() to paste_skip_na()

    @matanhakim
    matanhakim committed May 17, 2023
    Configuration menu
    Copy the full SHA
    7df603c View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. Add tests for multiple rows input in row_to_names()

    @matanhakim
    matanhakim committed May 19, 2023
    Configuration menu
    Copy the full SHA
    44c018f View commit details
    Browse the repository at this point in the history

  2. Fix issues from code review 

    Add documentation for `sep` argument
Fine-tune check for using "find_header" argument
Add input tests for `sep` argument
Rewrite name manipulation more efficiently
Handle NA column name to be "NA"
Update `remove_rows_above` to refer to the topmost row
Remove redundant function after using `paste_skip_na()`
    @matanhakim
    matanhakim committed May 19, 2023
    Configuration menu
    Copy the full SHA
    1466f38 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2023

  1. Default to lowest header row when removing rows

    @matanhakim
    matanhakim committed May 20, 2023
    Configuration menu
    Copy the full SHA
    0300ee8 View commit details
    Browse the repository at this point in the history

  2. Change quietly() to suppressWarnings()

    @matanhakim
    matanhakim committed May 20, 2023
    Configuration menu
    Copy the full SHA
    091126c View commit details
    Browse the repository at this point in the history

  3. Add sep argument documentation

    @matanhakim
    matanhakim committed May 20, 2023
    Configuration menu
    Copy the full SHA
    9025f54 View commit details
    Browse the repository at this point in the history

  4. Add test for multiple NA input to row_number

    @matanhakim
    matanhakim committed May 20, 2023
    Configuration menu
    Copy the full SHA
    f7dfa8a View commit details
    Browse the repository at this point in the history