Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paste_skip_na() #538

Merged
merged 3 commits into from
May 1, 2023
Merged

Add paste_skip_na() #538

merged 3 commits into from
May 1, 2023

Conversation

billdenney
Copy link
Collaborator

Fix #537

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #538 (40c172a) into main (d64c8bb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #538   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        26    +1     
  Lines         1148      1177   +29     
=========================================
+ Hits          1148      1177   +29     
Impacted Files Coverage Δ
R/paste_skip_na.R 100.00% <100.00%> (ø)

@billdenney billdenney requested a review from sfirke April 18, 2023 17:26
@billdenney
Copy link
Collaborator Author

@sfirke, this is ready for your review.

Copy link
Owner

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! I just have a question and a few small nits.

R/paste_skip_na.R Show resolved Hide resolved
R/paste_skip_na.R Outdated Show resolved Hide resolved
R/paste_skip_na.R Show resolved Hide resolved
R/paste_skip_na.R Outdated Show resolved Hide resolved
tests/testthat/test-paste_skip_na.R Show resolved Hide resolved
@billdenney
Copy link
Collaborator Author

@sfirke, I've taken care of them all, I think. Can you please take another look and merge, if it looks good?

@sfirke sfirke merged commit c3fd147 into main May 1, 2023
9 checks passed
@sfirke sfirke deleted the paste_skip_na branch May 1, 2023 16:23
@sfirke
Copy link
Owner

sfirke commented May 1, 2023

Merged. Thanks, Bill!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: paste_skip_na() function that skips NA values when pasting
2 participants