[WIP] Use vcluster auth when passing vcluster flag to user create #86
Conversation
|
Review changes with Changed Files
|
romiphadte
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds vcluster authentication support to the CLI through a new --vcluster flag for cluster user management commands.
- Added null check and filtering in
createKubeconfigto prevent invalid context entries when no user is available for a cluster - Implemented
--vclusterflag inclusters users addandclusters configcommands - Added kubectl integration to retrieve vcluster configuration from Kubernetes clusters
- Modified vcluster config to maintain original cluster API URL while using vcluster authentication
- Added fallback mechanism to regular kubeconfig generation if vcluster config retrieval fails
2 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
src/lib/clusters/clusters.tsx
Outdated
| const { execSync } = require("node:child_process"); | ||
| const vclusterConfig = execSync( | ||
| `kubectl get secret ${vclusterName} -n ${namespace} --template={{.data.config}} | base64 --decode`, | ||
| { encoding: "utf-8" } | ||
| ); |
There was a problem hiding this comment.
style: Using require("node:child_process") dynamically introduces a runtime dependency that might not be checked at build time. Consider importing at the top of the file.
src/lib/clusters/clusters.tsx
Outdated
| const { execSync } = require("node:child_process"); | ||
| const vclusterConfig = execSync( | ||
| `kubectl get secret ${vclusterName} -n ${namespace} --template={{.data.config}} | base64 --decode`, | ||
| { encoding: "utf-8" } | ||
| ); |
There was a problem hiding this comment.
logic: This introduces a hard dependency on kubectl being installed and in the PATH. Need to check for kubectl presence before attempting to use it.
src/lib/clusters/clusters.tsx
Outdated
| `kubectl get secret ${vclusterName} -n ${namespace} --template={{.data.config}} | base64 --decode`, | ||
| { encoding: "utf-8" } |
There was a problem hiding this comment.
style: This command will fail if the user doesn't have permissions to access the secret in the namespace. Add error handling for permission issues.
romiphadte
force-pushed
the
user/rphadte/use-vcluster-auth
branch
from
ef27a97 to
1185797
Compare
No description provided.