add configuration option to allow nullable annotation on return #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot, can you explain problem in details and example in issue. Please use link to issue in commit message. |
vdaniloff
force-pushed
the
allow-nullable-as-return-option
branch
from
ae573b4 to
95e928e
Compare
Jsr305AnnotationCheck sevntu-checkstyle#887
|
Created #887 and mentioned in commit |
|
@vdaniloff @romani Is there agreement on the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The great Jsr305 check resolves almost everyone needs for validation, but it does not allow nullable as return value annotation, requiring CheckForNull usage.
On the other hand this is in fact commonly used practice. Even #622 uses that in code snippet.
A new parameter has been added to the validation to allow using nullable.