infra: move wercker no-exception testing to diff.groovy #828

nrmancuso · 2021-02-13T17:16:48Z

infra: move wercker no-exception testing to diff.groovy

Right now, this PR is only a test to make sure that combined diff/launch .groovy will work as intended for no-exceptions testing. Once PR for checkstyle/contribution#529 is merged, we can change the repo in checkout-from back to checkstyle's contribution repo and review this PR.

coveralls · 2021-02-13T17:30:47Z

Coverage remained the same at 98.777% when pulling cfead7c on nmancus1:nmancus1-patch-1 into 53782d0 on sevntu-checkstyle:master.

romani · 2021-02-13T21:01:50Z

Failed at

Command: ./.ci/wercker.sh no-exception-spotbugs
CS_version: 8.29
SEVNTU_version: 1.38.0

nrmancuso · 2021-02-13T21:08:03Z

CS_version: 8.29

This is why it failed, I forgot to remove a testing repo of mine from projects file that contained a text block with \s, and 8.29 didn't have support for this escape yet.

romani · 2021-02-14T00:10:43Z

sevntu-checks/.ci/wercker.sh

@@ -28,13 +28,13 @@ no-exception-struts)
                     --non-recursive org.codehaus.mojo:exec-maven-plugin:1.3.1:exec)
  echo CS_version: ${CS_POM_VERSION}
  echo SEVNTU_version: ${SEVNTU_POM_VERSION}
-  checkout_from https://github.com/checkstyle/contribution.git
+  checkout_from "-b issue-529 https://github.com/nmancus1/contribution.git"


nrmancuso · 2021-02-14T14:35:16Z

Any usages of launch that are being replaced with diff that DO NOT use -i need to specify --allowExcludes now.

nrmancuso · 2021-02-14T22:03:01Z

The only difference in commands after checkstyle/contribution#546 is the -Dcheckstyle.failsOnError=false flag appended to all commands by diff.groovy:

Command: ./.ci/wercker.sh no-exception-struts
maven command from master: Running command: mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes=**/apache-struts/**/resources/**/* -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0
maven command from this PR: Running command: mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes=**/apache-struts/**/resources/**/* -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0 -Dcheckstyle.failsOnError=false

Command: ./.ci/wercker.sh no-exception-guava
maven command from master: mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0
maven command from this PR:mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0 -Dcheckstyle.failsOnError=false

Command: ./.ci/wercker.sh no-exception-hibernate-orm
maven command from master: mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0
maven command from this PR:mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0 -Dcheckstyle.failsOnError=false

Command: ./.ci/wercker.sh no-exception-spotbugs
maven command from master: mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0
maven command from master: mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes=**/spotbugs-with-excldues/eclipsePlugin-test/**/*,**/spotbugs-with-excldues/spotbugsTestCases/**/*,**/spotbugs-with-excldues/JSR305-testCases/**/* -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0

maven command from this PR:mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0 -Dcheckstyle.failsOnError=false
maven command from this PR:mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes=**/spotbugs-with-excldues/eclipsePlugin-test/**/*,**/spotbugs-with-excldues/spotbugsTestCases/**/*,**/spotbugs-with-excldues/JSR305-testCases/**/* -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0 -Dcheckstyle.failsOnError=false

Command: ./.ci/wercker.sh no-exception-spring-framework
maven command from master: mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0
maven command from this PR:mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0 -Dcheckstyle.failsOnError=false

Command: ./.ci/wercker.sh no-exception-hbase
maven command from master: mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0
maven command from this PR:mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0 -Dcheckstyle.failsOnError=false

Command: ./.ci/wercker.sh no-exception-Pmd-elasticsearch-lombok-ast
maven command from master: mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes=**/pmd/pmd-java/src/test/**/*,**/pmd/cpd/files/* -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0
maven command from master: mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes=**/lombok-ast/test/**/* -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0
maven command from master: mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0
maven command from this PR:Running command: mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes=**/pmd/pmd-java/src/test/**/*,**/pmd/cpd/files/* -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0 -Dcheckstyle.failsOnError=false

maven command from this PR:mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes=**/lombok-ast/test/**/* -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0 -Dcheckstyle.failsOnError=false

maven command from this PR:mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0 -Dcheckstyle.failsOnError=false

Command: ./.ci/wercker.sh no-exception-alot-of-projects
maven command from master: mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0
maven command from master: mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0
maven command from master: mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes=**/apache-ant/src/tests/**/*,**/apache-ant/src/etc/testcases/ -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0
maven command from master: mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0
maven command from master: mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0
maven command from master: mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0

maven command from this PR:mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0 -Dcheckstyle.failsOnError=false

maven command from this PR:mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes=**/apache-ant/src/tests/**/*,**/apache-ant/src/etc/testcases/ -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0 -Dcheckstyle.failsOnError=false

maven command from this PR:mvn -e --batch-mode site -Dcheckstyle.config.location=checks-sevntu-error.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.29 -Dsevntu-checkstyle.version=1.38.0 -Dcheckstyle.failsOnError=false

sevntu-checks/.ci/wercker.sh

romani

after merge of contribution PR, this PR need to be updated to use upstream contribution repo

nrmancuso force-pushed the nmancus1-patch-1 branch from 9a7e88a to 5da9a88 Compare February 13, 2021 21:06

nrmancuso force-pushed the nmancus1-patch-1 branch 2 times, most recently from ab32c68 to 7e846de Compare February 13, 2021 21:54

romani reviewed Feb 14, 2021

View reviewed changes

nrmancuso marked this pull request as draft February 14, 2021 14:41

nrmancuso force-pushed the nmancus1-patch-1 branch from 7e846de to 6afd88f Compare February 14, 2021 17:09

nrmancuso mentioned this pull request Feb 14, 2021

Issue #529: Deprecate launch.groovy and merge functionality into diff.groovy checkstyle/contribution#546

Merged

nrmancuso force-pushed the nmancus1-patch-1 branch from 1d565ce to 9e091c7 Compare February 14, 2021 21:44

nrmancuso force-pushed the nmancus1-patch-1 branch from 9e091c7 to 6251c6a Compare March 21, 2021 14:18

nrmancuso commented Mar 23, 2021

View reviewed changes

sevntu-checks/.ci/wercker.sh Outdated Show resolved Hide resolved

nrmancuso force-pushed the nmancus1-patch-1 branch 2 times, most recently from e92c7e0 to cb5d453 Compare April 3, 2021 19:27

nrmancuso marked this pull request as ready for review April 3, 2021 19:34

nrmancuso force-pushed the nmancus1-patch-1 branch 8 times, most recently from 0eabd9d to a7c441c Compare April 7, 2021 18:36

romani approved these changes Apr 10, 2021

View reviewed changes

infra: move wercker no-exception testing to diff.groovy

cfead7c

nrmancuso force-pushed the nmancus1-patch-1 branch from a7c441c to cfead7c Compare April 11, 2021 02:34

romani approved these changes Apr 11, 2021

View reviewed changes

romani merged commit 19029d8 into sevntu-checkstyle:master Apr 11, 2021

nrmancuso mentioned this pull request Apr 26, 2021

Deprecate launch.groovy and merge functionality into diff.groovy checkstyle/contribution#529

Closed

rnveach mentioned this pull request Oct 29, 2022

minor: simplify scripts and ensure we are able to rerun #927

Merged

nrmancuso deleted the nmancus1-patch-1 branch October 31, 2022 03:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

infra: move wercker no-exception testing to diff.groovy #828

infra: move wercker no-exception testing to diff.groovy #828

nrmancuso commented Feb 13, 2021

coveralls commented Feb 13, 2021 •

edited

Loading

romani commented Feb 13, 2021

nrmancuso commented Feb 13, 2021 •

edited

Loading

romani Feb 14, 2021

nrmancuso commented Feb 14, 2021 •

edited

Loading

nrmancuso commented Feb 14, 2021 •

edited

Loading

romani left a comment

infra: move wercker no-exception testing to diff.groovy #828

infra: move wercker no-exception testing to diff.groovy #828

Conversation

nrmancuso commented Feb 13, 2021

coveralls commented Feb 13, 2021 • edited Loading

romani commented Feb 13, 2021

nrmancuso commented Feb 13, 2021 • edited Loading

romani Feb 14, 2021

Choose a reason for hiding this comment

nrmancuso commented Feb 14, 2021 • edited Loading

nrmancuso commented Feb 14, 2021 • edited Loading

romani left a comment

Choose a reason for hiding this comment

coveralls commented Feb 13, 2021 •

edited

Loading

nrmancuso commented Feb 13, 2021 •

edited

Loading

nrmancuso commented Feb 14, 2021 •

edited

Loading

nrmancuso commented Feb 14, 2021 •

edited

Loading