Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #734: Integrate 'Jsr305Annotations' plugin #728

Closed
wants to merge 2 commits into from

Conversation

mbert
Copy link
Contributor

@mbert mbert commented Mar 6, 2019

Issue #734: This PR adds the Jsr305CheckstylePlugin plugin which has so far been hosted in its own repository. It allows enforcing the use of the "nullness" annotations in code in order to both support static code analysis and understandability of code.

The code now passes the test suite as well as the CheckStyle check. Since this is my first contribution to the sevntu project, please be patient if I forgot something :)

@mbert mbert changed the title Issue #727: Integrate 'Jsr305Annotations' plugin Issue #734: Integrate 'Jsr305Annotations' plugin Apr 2, 2019
@rnveach
Copy link
Contributor

rnveach commented Apr 7, 2019

@mbert please rebase code on latest master and start fixing CI failures. Please keep the number of commits at 1.
Also consider my comment in main issue about maybe everything in this 1 check might be too much and if there is anyway to split it, either each class to its own file or reducing the complexity of the check into many checks.

@mbert
Copy link
Contributor Author

mbert commented Apr 12, 2019

I will upload a new PR assigned to the new ticket #734.

@mbert mbert closed this Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants