Skip to content
This repository has been archived by the owner on Feb 16, 2025. It is now read-only.

Use surfman that has glow instead of GL_gen #255

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sagudev
Copy link
Member

@sagudev sagudev commented Nov 21, 2024

Depends on servo/surfman#321

@sagudev sagudev marked this pull request as ready for review January 14, 2025 12:36
@sagudev sagudev requested a review from mrobinson January 14, 2025 12:52
Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a couple comments:

@@ -35,7 +35,7 @@ openxr = { version = "0.19", optional = true }
serde = { version = "1.0", optional = true }
glow = "0.16"
raw-window-handle = "0.6"
surfman = { git = "https://github.com/servo/surfman", rev = "300789ddbda45c89e9165c31118bf1c4c07f89f6", features = [
surfman = { git = "https://github.com/servo/surfman", rev = "e78ea1b24e1de57f24fc761186d8e9d9e43d660a", features = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make a surfman release now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping to get this and land companion PR (this way we can still do revert if something goes wrong) then do release on weekend. See servo/surfman#325 (comment)

webxr/glwindow/mod.rs Outdated Show resolved Hide resolved
Signed-off-by: sagudev <[email protected]>
@sagudev sagudev requested a review from mrobinson January 15, 2025 09:52
Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's make the surfman release before landing this. Thank you for all of the hard work!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants