-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stylo compilation on wasm32-unknown-unknown
target
#78
Open
nicoburns
wants to merge
7
commits into
servo:main
Choose a base branch
from
nicoburns:fix-wasm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,810
−604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any ancestors of this commit are from upstream mozilla-central, with some filtering and renaming. Our patches and sync tooling start here. The sync tooling has all been squashed into this commit, based on: https://github.com/servo/stylo/commits/64731e10dc8ef87ef52aa2fb9f988c3b2530f3a7
This is a rebase of bedab74
Signed-off-by: Oriol Brufau <[email protected]>
Servo will use a forked version of `malloc_size_of` so that it does not push depenencies down into Stylo. Corresponding upstream change: https://phabricator.services.mozilla.com/D229764 Signed-off-by: Martin Robinson <[email protected]>
Submitted upstream as https://bugzilla.mozilla.org/show_bug.cgi?id=1933015 |
Signed-off-by: Nico Burns <[email protected]>
Looks like this needs a bit of refinement since it was reverted upstream. |
Yeah, this is causing some kind of issue with Gecko's C bindings to Stylo. Will need to investigate. |
* Enable prefers-color-scheme for Servo Signed-off-by: Nico Burns <[email protected]> * Dedup PrefersColorScheme type --------- Signed-off-by: Nico Burns <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1933015