Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jsstreams #540

Merged
merged 4 commits into from
Dec 21, 2024
Merged

Remove jsstreams #540

merged 4 commits into from
Dec 21, 2024

Conversation

sagudev
Copy link
Member

@sagudev sagudev commented Dec 18, 2024

Now that servo/servo#34064 landed we can remove this. This is needed so we can start using mozjs artifacts again in servo CI.

This is nice:
-18k lines

Copy link
Member

@wusyong wusyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with manually setting MOZJS_ARCHIVE and it is working!
I'll approve here first in case you want to merge it when it's ready.
Whole Servo workflow became very slow today.

image

@sagudev
Copy link
Member Author

sagudev commented Dec 18, 2024

I'm waiting for servo/servo#34629 to create companion PR in servo.

sagudev added a commit to sagudev/servo that referenced this pull request Dec 21, 2024
@sagudev sagudev marked this pull request as ready for review December 21, 2024 10:18
@sagudev sagudev added this pull request to the merge queue Dec 21, 2024
Merged via the queue into servo:main with commit 29d28f6 Dec 21, 2024
27 checks passed
github-merge-queue bot pushed a commit to servo/servo that referenced this pull request Dec 21, 2024
* Update to mozjs without streams

servo/mozjs#540
Signed-off-by: sagudev <[email protected]>

* switch to servo/mozjs

Signed-off-by: sagudev <[email protected]>

---------

Signed-off-by: sagudev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants