-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jsstreams #540
Merged
Merged
Remove jsstreams #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
sagudev
force-pushed
the
remove-jsstreams
branch
from
December 18, 2024 06:18
ee395b8
to
be91a41
Compare
jschwe
reviewed
Dec 18, 2024
wusyong
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm waiting for servo/servo#34629 to create companion PR in servo. |
3 tasks
sagudev
added a commit
to sagudev/servo
that referenced
this pull request
Dec 21, 2024
servo/mozjs#540 Signed-off-by: sagudev <[email protected]>
3 tasks
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Dec 21, 2024
* Update to mozjs without streams servo/mozjs#540 Signed-off-by: sagudev <[email protected]> * switch to servo/mozjs Signed-off-by: sagudev <[email protected]> --------- Signed-off-by: sagudev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that servo/servo#34064 landed we can remove this. This is needed so we can start using mozjs artifacts again in servo CI.
This is nice: