Skip to content

Conversation

@ricardozanini
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:
When releasing we were getting:

Error: [ERROR] Failed to execute goal on project serverlessworkflow-impl-jackson-jwt: Could not resolve dependencies for project io.serverlessworkflow:serverlessworkflow-impl-jackson-jwt:jar:7.3.0.Final
Error: [ERROR] dependency: io.serverlessworkflow:serverlessworkflow-impl-jackson:jar:7.3.0.Final (compile)
Error: [ERROR] 	Could not find artifact io.serverlessworkflow:serverlessworkflow-impl-jackson:jar:7.3.0.Final in central (https://repo.maven.apache.org/maven2)
Error: [ERROR] -> [Help 1]
Error: [ERROR] 
Error: [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
Error: [ERROR] Re-run Maven using the -X switch to enable full debug logging.
Error: [ERROR] 
Error: [ERROR] For more information about the errors and possible solutions, please read the following articles:
Error: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
Error: [ERROR] 
Error: [ERROR] After correcting the problems, you can resume the build with the command
Error: [ERROR]   mvn <args> -rf :serverlessworkflow-impl-jackson-jwt

This is because impl-jackson was a POM, not a JAR, but was still being imported as a JAR by submodules.

In the future, we can introduce starters packages a lá SpringBoot for other bundles we plan to distribute.

Special notes for reviewers:
Need this to release.

Additional information (if needed):
Additionally, we add a small guardrail for the release process to check our GPG keys. It was failing before because the keys had expired.

@fjtirado
Copy link
Collaborator

For the Jackson issue, I prefer the alternative I provided on #906. Do not generate a fake jar, but just use <type>pom</type> when using the dependency.

@fjtirado fjtirado merged commit 335f670 into serverlessworkflow:main Oct 24, 2025
3 checks passed
@ricardozanini ricardozanini deleted the update-gpg branch October 24, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants