Skip to content

Conversation

@treblereel
Copy link
Collaborator

@treblereel treblereel commented Sep 23, 2025

[Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:
Fix #477

Special notes for reviewers:

Additional information (if needed):]

@treblereel treblereel marked this pull request as draft September 23, 2025 17:12
@treblereel
Copy link
Collaborator Author

I'm gonna add more tests soon

@treblereel treblereel marked this pull request as ready for review October 9, 2025 23:57
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
Comment on lines +75 to +77
} catch (Exception e) {
throw new RuntimeException(e);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not need this block, you just want to propagate all exception that are not workflow (because if it workflow you want to try the next server), which will happen anyway if you delete this block

improve ExpressionURISupplier

Signed-off-by: Dmitrii Tikhomirov <[email protected]>
@mcruzdev
Copy link
Contributor

Hi @treblereel, nice pull request!

I would like to mention the redirect option, are you planning to do in another pull request?

@mcruzdev
Copy link
Contributor

@treblereel
Copy link
Collaborator Author

@mcruzdev OpenAPI is quite a large topic, and I prefer to work on it in small iterations. It makes reviewing and testing easier

@treblereel treblereel self-assigned this Oct 20, 2025
@ricardozanini
Copy link
Member

@mcruzdev feel free to add it - I'm merging this one.

@ricardozanini ricardozanini merged commit ee44c19 into serverlessworkflow:main Oct 20, 2025
3 checks passed
@mcruzdev
Copy link
Contributor

@mcruzdev OpenAPI is quite a large topic, and I prefer to work on it in small iterations. It makes reviewing and testing easier

I agree with you.

@mcruzdev feel free to add it - I'm merging this one.

Yeah, I can work on it.

@treblereel
Copy link
Collaborator Author

@mcruzdev ping me if you have any q

@fjtirado
Copy link
Collaborator

fjtirado commented Oct 21, 2025

@mcruzdev @treblereel Ill be heavily refactoring openAPI implementation those days because of #879, so its better to wait to add more functionality for the time being.
@mcruzdev in the meantime you can start looking to https://github.com/serverlessworkflow/specification/blob/main/dsl-reference.md#shell-process, which is a long and independent task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add OpenAPI task implementation

4 participants