-
Notifications
You must be signed in to change notification settings - Fork 49
Add OpenAPI task implementation #804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm gonna add more tests soon |
impl/http/src/main/java/io/serverlessworkflow/impl/executors/http/ExpressionURISupplier.java
Show resolved
Hide resolved
impl/openapi/src/main/java/io/serverlessworkflow/impl/executors/openapi/OpenAPIExecutor.java
Outdated
Show resolved
Hide resolved
impl/openapi/src/main/java/io/serverlessworkflow/impl/executors/openapi/OpenAPIExecutor.java
Outdated
Show resolved
Hide resolved
impl/openapi/src/main/java/io/serverlessworkflow/impl/executors/openapi/HttpCallAdapter.java
Outdated
Show resolved
Hide resolved
impl/openapi/src/main/java/io/serverlessworkflow/impl/executors/openapi/OpenAPIExecutor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
impl/http/src/main/java/io/serverlessworkflow/impl/executors/http/HttpExecutor.java
Outdated
Show resolved
Hide resolved
| } catch (Exception e) { | ||
| throw new RuntimeException(e); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do not need this block, you just want to propagate all exception that are not workflow (because if it workflow you want to try the next server), which will happen anyway if you delete this block
improve ExpressionURISupplier Signed-off-by: Dmitrii Tikhomirov <[email protected]>
|
Hi @treblereel, nice pull request! I would like to mention the redirect option, are you planning to do in another pull request? |
|
To be more specific, this one https://github.com/serverlessworkflow/specification/blob/main/dsl-reference.md#properties-6 redirect |
|
@mcruzdev OpenAPI is quite a large topic, and I prefer to work on it in small iterations. It makes reviewing and testing easier |
|
@mcruzdev feel free to add it - I'm merging this one. |
|
@mcruzdev ping me if you have any q |
|
@mcruzdev @treblereel Ill be heavily refactoring openAPI implementation those days because of #879, so its better to wait to add more functionality for the time being. |
[Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Fix #477
Special notes for reviewers:
Additional information (if needed):]