Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates instruction to install source-map-support as regular dependency #211

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arturopie
Copy link

source-map-support is imported inside the function, so I don't think it should be installed as a dev dependency.

If I install source-map-support as a dev dependency, and invoke the function on AWS Lambda, I get the following error Runtime.ImportModuleError: Error: Cannot find module 'source-map-support/register'

I'm new to Serverless and Typescript, so I might be completely mistaken here. Let me know.

updates instruction to install source-map-support as a regular dependency, since it's imported inside the function
@dimadesu
Copy link

@arturopie This tripped me up today. Thanks for logging the issue, this definitely needs to be updated.

I moved source-map-support from dev dependency to the dependency and that fixed the problem for me. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants