Updates instruction to install source-map-support as regular dependency #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates instruction to install source-map-support as a regular dependency, since it's imported inside the function
|
@arturopie This tripped me up today. Thanks for logging the issue, this definitely needs to be updated. I moved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
source-map-support is imported inside the function, so I don't think it should be installed as a dev dependency.
If I install source-map-support as a dev dependency, and invoke the function on AWS Lambda, I get the following error
Runtime.ImportModuleError: Error: Cannot find module 'source-map-support/register'I'm new to Serverless and Typescript, so I might be completely mistaken here. Let me know.