-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to dereference symlinks #181
base: master
Are you sure you want to change the base?
Add option to dereference symlinks #181
Conversation
+1 I've been using this with in a serverless monorepo along side |
Would this make serverless-plugin-monorepo obsolete? |
path.resolve(path.join(BUILD_FOLDER, 'node_modules')) | ||
path.resolve(path.join(BUILD_FOLDER, 'node_modules')), | ||
{ | ||
dereference: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ Btw, I think LOC 177 needs to have this change too (at least, in our case we needed to patch both places)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm, had to update both places.
+1 Could we possible have this merged? It's a areal blocker when a monorepo is used. We use pnpm and have to patch this with patch-package :( |
Please merge this. This allows usage of this plugin in a monorepo setup where node_module deps are symlinked. |
Bumping, can we possibly get this merged please? 🙏 Solved all of my issues while working in a monorepo (managed with pnpm). |
How do you also include subdependencies in a bundle? I noticed this PR to help only with direct deps, but their deps are not being included. |
Is this project dead? |
Adds the
dereference
option to flatten symlinks when copying node_modules. This is useful in lerna environments which might symlink a node_module within the same project.https://github.com/jprichardson/node-fs-extra/blob/HEAD/docs/copy-sync.md