Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong parameter path.copy & fix artifact #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomzaku
Copy link

@tomzaku tomzaku commented Jul 17, 2019

@JackCuthbert
Copy link
Contributor

Thanks for doing this, @tomzaku! Your changes look good but do you mind updating your commit message to read fix: wrong parameter path.copy & fix artifact so the release bot can publish the version correctly?

When I have some time this weekend I'll try to repro these issues too 😄

@tomzaku
Copy link
Author

tomzaku commented Jul 19, 2019

@JackCuthbert done!

@JackCuthbert
Copy link
Contributor

This appears to be specific to serverless-webpack users. Your fix resolves the issue when someone uses webpack, but breaks non-webpack projects (at least it did for me).

The following error occurs when running your fix without serverless-webpack.

Serverless: Compiling with Typescript...
Serverless: Typescript compiled.
Serverless: Packaging service...
Serverless: Excluding development dependencies...
Unhandled rejection Error: ENOENT: no such file or directory, open '/home/jack/Code/serverless-plugins/.serverless/serverless-typescript-debugging.zip'

Additionally, the serverless offline integration fails with a Cannot find module error during function invocation when using serverless-webpack. I copied as much of your webpack config as I could, is there something I did wrong here to cause this one?

Do you know how we might support both using webpack and a zero-config option with just the TS compiler?

@ghost
Copy link

ghost commented Nov 7, 2019

Any plan to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants