Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wildcard SANs and log invalid SANs #280

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Conversation

paulschwarzenberger
Copy link
Contributor

  • support a wildcard SAN, e.g. *.example.com
  • continue to check domain is valid before including in SANs
  • create a CloudWatch log entry if a domain has been rejected because it's invalid

@paulschwarzenberger paulschwarzenberger requested a review from a team as a code owner December 5, 2024 20:33
@paulschwarzenberger paulschwarzenberger merged commit 2da8376 into main Dec 5, 2024
17 checks passed
@paulschwarzenberger paulschwarzenberger deleted the wildcard-sans branch December 5, 2024 20:34
@paulschwarzenberger paulschwarzenberger linked an issue Dec 5, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wildcard domain names not included in SANs
1 participant