Merge pull request #4 from q-solution/python12

Omit pylint from Prospector tools until v3 is supported
serverless-ca · Jan 27, 2024 · 61a342e · 61a342e
2 parents efd00d1 + 04cf38d
commit 61a342e
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 6 deletions.
diff --git a/.github/workflows/python.yml b/.github/workflows/python.yml
@@ -32,7 +32,10 @@ jobs:
 
       - name: Prospector
         run: |
-          prospector --no-autodetect
+          prospector tests
+
+          # don't use pylint until prospector supports pylint 3.x, required for Python 3.12
+          prospector modules/terraform-aws-ca-lambda --without-tool pylint
 
       - name: prepare reports dir
         run: mkdir --parents ${{runner.temp}}/reports_sast_python/

diff --git a/modules/terraform-aws-ca-lambda/README.MD b/modules/terraform-aws-ca-lambda/README.MD
@@ -2,13 +2,17 @@
 * Deploys AWS Lambda functions forming part of serverless CA solution
 * Submodule of terraform-aws-ca
 
-## Local Python development - Windows
+## Local Python development
 * create virtual environment
-```powershell
+```bash
 cd modules\terraform-aws-ca-lambda
 python -m venv .venv
 ```
-* activate virtual environment on Windows
+* activate virtual environment (Linux / MacOS)
+```bash
+source .venv/bin/activate
+```
+* activate virtual environment (Windows)
 ```powershell
 .venv\Scripts\Activate
 ```

diff --git a/modules/terraform-aws-ca-lambda/requirements-dev.txt b/modules/terraform-aws-ca-lambda/requirements-dev.txt
@@ -1,7 +1,7 @@
 boto3==1.20.24
 black==22.10.0
 cryptography==41.0.6
-prospector==1.9.0
+prospector==1.10.3
 bandit==1.7.5
 pyOpenSSL==23.2
 requests==2.31.0

diff --git a/tests/requirements-dev.txt b/tests/requirements-dev.txt
@@ -5,7 +5,7 @@ black==22.10.0
 cryptography == 41.0.7
 asn1crypto == 1.5.1
 certvalidator == 0.11.1
-prospector==1.9.0
+prospector==1.10.3
 bandit==1.7.5
 pytest==7.4.4
 validators==0.22.0