Fix #142: catch StopIteration and return InvalidProductError #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In other products, I found the same usecase with a StopIteration we should catch. |
jteulade
commented
May 15, 2024
| except (FileNotFoundError, IndexError): | ||
| LOGGER.warning( | ||
| except (FileNotFoundError, IndexError, StopIteration): | ||
| raise InvalidProductError( |
There was a problem hiding this comment.
raise an exception instead of LOGGER. To confirm with @remi-braun
jteulade
force-pushed
the
142-stopiteration-s2-product
branch
from
ec10e56
to
a0f163c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Please review the guidelines for contributing to this repository.
Description
Please describe your pull request.
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
Thank you!