Merge pull request #4001 from serlo/quickfix-auth-error-page

fix: use router inside useEffect
serlo · Jul 29, 2024 · 6838a0a · 6838a0a
2 parents 17edee5 + 379d442
commit 6838a0a
Showing 1 changed file with 17 additions and 17 deletions.
diff --git a/apps/web/src/pages/auth/error.tsx b/apps/web/src/pages/auth/error.tsx
@@ -26,6 +26,22 @@ function Error() {
   const authStrings = useInstanceData().strings.auth
 
   useEffect(() => {
+    if (
+      hasFlowErrorFieldError(error) &&
+      error.error.message.includes('ERR_BAD_ROLE')
+    ) {
+      showToastNotice(authStrings.badRole, 'warning', 5000)
+      void router.push(loginUrl)
+      return
+    }
+
+    if (isProduction && error) {
+      triggerSentry({ message: 'Auth error in error flow', data: error })
+      showToastNotice(authStrings.somethingWrong, 'warning', 5000)
+      void router.push(loginUrl)
+      return
+    }
+
     if (!router.isReady || error) return
 
     kratos
@@ -46,23 +62,7 @@ function Error() {
 
         return Promise.reject(err)
       })
-  }, [id, router, router.isReady, error])
-
-  if (
-    hasFlowErrorFieldError(error) &&
-    error.error.message.includes('ERR_BAD_ROLE')
-  ) {
-    showToastNotice(authStrings.badRole, 'warning', 5000)
-    void router.push(loginUrl)
-    return
-  }
-
-  if (isProduction) {
-    triggerSentry({ message: 'Auth error in error flow', data: error })
-    showToastNotice(authStrings.somethingWrong, 'warning', 5000)
-    void router.push(loginUrl)
-    return
-  }
+  }, [id, router, error, authStrings])
 
   return error ? <pre>{JSON.stringify(error, null, 2)}</pre> : null
 }