Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight all parts of the Open statement #99

Open
3 tasks
serkonda7 opened this issue Nov 28, 2023 · 0 comments
Open
3 tasks

Highlight all parts of the Open statement #99

serkonda7 opened this issue Nov 28, 2023 · 0 comments

Comments

@serkonda7
Copy link
Owner

serkonda7 commented Nov 28, 2023

Description and Reproduction Steps

Not all parts of the open statement are yet highlighted.

https://learn.microsoft.com/en-us/office/vba/language/reference/user-interface-help/open-statement

  • mode keywords
  • acces keywords
  • lock keywords

Current Behavior

x

Expected Behavior

X

Additional Information

A valid concern was raised in #96 (comment):

In my opinion, it's not necessary to highlight the mode and access keywords inside the Open statement. Otherwise, the whole line of code is pretty much highlighted and I feel like too much highlighting is almost like no highlighting at all.

That being said, I'm not totally opposed to the idea, but that will need some more playing around with regex to make it work.

I think, we could use the alternate highlight color (e.g. purple) instead of the default blue keyword one. But otherwise a almost completely colored line in fact defeats it's purpose.

That being said, this issue is not yet decided on.

Environment details

X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant