Open myPath for input not highlighted

[sancarn]

Description and Reproduction Steps

Keywords not highlighted in:

  Open sPath For Input as #ff
    Input #ff, sContent
  Close #ff

[serkonda7]

Confirmed, feel free to propose a patch.
https://learn.microsoft.com/en-us/office/vba/language/reference/user-interface-help/open-statement

[DecimalTurn]

I'd suggest making a new keyword category just for I/O related keywords with scope name keyword.io.vba.

Here's the ones I could find:

• Open
• Close
• Input
• Line Input
• Lock, Unlock
• Print
• Seek
• Width
• Get
• Put
• Write

[serkonda7]

@DecimalTurn thank you for the list. I have some time today and will implement it.

[serkonda7]

The changes are here: 33305c3

The test covers not all keywords yet.

Also some fine adjustments to the Open statement are needed. But this exceeds my time for now so I have opened #99

[DecimalTurn]

In my opinion, it's not necessary to highlight the mode and access keywords inside the Open statement. Otherwise, the whole line of code is pretty much highlighted and I feel like too much highlighting is almost like no highlighting at all.

That being said, I'm not totally opposed to the idea, but that will need some more playing around with regex to make it work.

In the meantime, it would be weird that the Input keyword would be highlighted inside the Open statement and not the others (Append, Binary, Output, and Random). I tried something with a lookahead here to fix that. I'm just wondering if that's something that would cause issues with GitHub Linguist like we had to fix for lookbehind that were not of fixed length (#80) 🤔.

[DecimalTurn]

I managed to use only a fixed length lookahead here. Let me know your thoughts.

[serkonda7]

@DecimalTurn btw, I included your concern from the comment in #99