refactor(no-release): make mypy standalone #608
Conversation
huxuan
force-pushed
the
xuan.hu/mypy-standalone
branch
10 times, most recently
from
f7568a9 to
718d68c
Compare
huxuan
force-pushed
the
xuan.hu/mypy-standalone
branch
from
fdb618d to
960927e
Compare
Yep, it needs a no-release scope. |
msclock
changed the title
| @@ -50,7 +50,7 @@ repos: | |||
| pass_filenames: false | |||
| - id: mypy | |||
| name: mypy | |||
| entry: mypy --python-executable $(pdm info --python) | |||
| entry: bash -c "mypy --python-executable $(pdm info --python) $@" -- | |||
There was a problem hiding this comment.
Does it work on win? I don't confirm the bash is always available on win.
There was a problem hiding this comment.
Good question, I never tried it - -
There was a problem hiding this comment.
I mean it seems not to support pre-commit on win. And the pre-commit is absent in the Makefile or in CI. So it can't verify its working.
There was a problem hiding this comment.
Yes, I will try it when Win is available. It should fail when I try to push the code, I also feel a little confused why it does not take effect then. Actually, I did not realize the problem until I try to push something else and it failed.
There was a problem hiding this comment.
After some investigation, there is no easy solution for cross-platform command substitution or environment variable substitution. The maintainer of pre-commit also suggests the bash -c and env approach. :(
huxuan
force-pushed
the
xuan.hu/mypy-standalone
branch
3 times, most recently
from
b7eb944 to
ec375a8
Compare
|
After consideration, I think we should keep Thanks for all the challenges and pushing back. I really appreciate the collaboration. |
This is a first step for #465, mypy is the most special case and fortunately we make it work.
Any comments are welcome.
📚 Documentation preview 📚: https://ss-python--608.org.readthedocs.build/en/608/