chore: change repo_host_type to repo_platform #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huxuan
force-pushed
the
xuan.hu/repo_platform
branch
from
b5e2699 to
9e6ea4a
Compare
|
BTW, this change makes jinja conditional judgment easier, and I would adopt this to ss-cpp.😀 |
|
I've done reviewing. If we have no problem with my suggestion, I will pass it an approval. |
Hi msclock, I did not see any review comments, maybe you forget to send it out? Let me know if I missed anything. |
|
Just a note, we should mention supporting different platforms in Features. |
msclock
requested changes
May 10, 2024
Co-authored-by: msclock <[email protected]> Signed-off-by: Xuan (Sean) Hu <[email protected]>
Good catch, buddy~ Changed as suggested. |
msclock
approved these changes
May 10, 2024
|
🎉 This PR is included in version 0.0.51 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://ss-python--533.org.readthedocs.build/en/533/