Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First quick and dirty attempt to migrate from
Newtonsoft.Json
toSystem.Text.Json
See #22 and datalust/seq-api#125
@nblumhardt WARNING: this PR is for your reference only: please review it carefully!!!!
All the tests on this repo are passing, but probably there are some API names are no more correct.
i.e.
serilog-formatting-compact-reader/src/Serilog.Formatting.Compact.Reader/LogEventReader.cs
Line 109 in b678843
now becomes
serilog-formatting-compact-reader/src/Serilog.Formatting.Compact.Reader/LogEventReader.cs
Line 123 in 4f1918c
but probably the name
ReadFromJsonElement
is more appropriated thanReadFromJObject
obviously there are also breaking changes when the public API references
Newtonsoft.Json