Allow logout function to receive a HeadersInit #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reichhartd
changed the title
|
@sergiodxa Maybe you can find time to look over this small PR? 🙂 |
sergiodxa
approved these changes
May 30, 2024
sergiodxa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the logout functionality to handle the deletion of additional cookies beyond the authentication cookie managed by
remix-auth.Changes:
headersparameter to thelogoutfunction.Set-Cookieheaders, allowing for the clearing of various session cookies.This enhancement is crucial for instances where multiple cookies are used and need to be cleared to ensure a user is completely logged out.