-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: alternative websocket template was not used in dashboard; Move templates_alt from application to config #1017
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,7 @@ Define('DB_USER', 'root'); | |
Define('DB_PASSWORD', ''); | ||
|
||
Define('DIR_TEMPLATES', "./templates/"); | ||
Define('ALTERNATIVE_TEMPLATES', "/templates_alt/"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. тут наверное не совсем корректный формат имени папки -- наверное должно быть "./templates_alt/" ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Да, тут я ошибся. Спасибо что заметили) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Вы можете отредактировать, когда смержите пул реквест? или нужно создавать новый? |
||
Define('DIR_MODULES', "./modules/"); | ||
Define('DEBUG_MODE', 1); | ||
Define('UPDATES_REPOSITORY_NAME', 'smarthome'); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А это действительно нужно? На сколько я помню, parser сам по себе поддерживает альтернативные шаблоны и принудительно для каждого файла нет необходимости его указывать, достаточно лишь чтобы была задана константа пути к альтернативным шаблонам.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Альтернативный шаблон websockets.html не работал именно во фриборде