Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated requirements for WA message #2961

Merged
merged 1 commit into from
May 30, 2024
Merged

Updated requirements for WA message #2961

merged 1 commit into from
May 30, 2024

Conversation

IanMayo
Copy link
Contributor

@IanMayo IanMayo commented May 28, 2024

Fixes #2960

@IanMayo IanMayo temporarily deployed to serge-2960-wa-template-tzar2l2 May 28, 2024 09:40 Inactive
@IanMayo
Copy link
Contributor Author

IanMayo commented May 28, 2024

This branch is using the legacy JSON-Editor.

We have an issue in the layout for the legacy JSON-Editor, it's the two scroll-bars that are displayed (see below).

@lilitkarapetyan - could you help us out by fixing the layout so that they are not displayed? The fix will be a new commit in the branch for this PR, please.

image

@Tristina1788
Copy link
Collaborator

@IanMayo, @lilitkarapetyan When I send new message without input, it will get the same content which the last message

Steps:

  1. Playgame with role Blue- Blue 3rd Party
  2. Send the first message with some input content
  3. Send the second new message without input infor message
  4. Notice the second message has same content with the first message
Message_get_old_content_message_when_send_message_without_input.mp4

@IanMayo
Copy link
Contributor Author

IanMayo commented May 29, 2024

@IanMayo, @lilitkarapetyan When I send new message without input, it will get the same content which the last message

Steps:

  1. Playgame with role Blue- Blue 3rd Party
  2. Send the first message with some input content
  3. Send the second new message without input infor message
  4. Notice the second message has same content with the first message

Hello @Tristina1788 - that's another issue related to the player experience for new message templates. I'd like this PR to focus on the admin pages. So could you create that as a new issue please?

Captured as #2963

@IanMayo IanMayo merged commit bd65fc4 into develop May 30, 2024
3 checks passed
@IanMayo IanMayo deleted the 2960_WA_Template branch May 30, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to WA template
2 participants