Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new models #1393

Closed
wants to merge 33 commits into from
Closed

Conversation

Smartappli
Copy link
Contributor

Add support for Falcon 11B
Add support for Gemma-2-9B
Add support for Gemma-2-9B-Instruct
Add support for Gemma-2-27B
Add support for Gemma-2-27B-Instruct
Add support for Mathastral 7B
Add support for Meta-Llama-3.1 8B
Add support for Meta-Llama-3.1 8B-Instruct
Add support for Meta-Llama-3.1-70B
Add support for Meta-Llama-3.1 70B-Instruct
Add support for Mistral-Nemo-Instruct-2407
Add support for OpenChat 3.6
Add support for Phi 3.1-mini-4k-instruct
Add support for Phi 3.1-mini-128k-instruct

Copy link
Contributor

coderabbitai bot commented Jul 28, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The recent updates enhance the README.md by refining the formatting of environment variable and model specifications, improving clarity and consistency. Additionally, the scripts/serge.env file has been updated to a newer version of the LLAMA Python library, ensuring better performance and features without altering existing configurations. Overall, these changes aim to improve documentation usability and maintain application functionality.

Changes

File Change Summary
README.md Updated formatting for environment variables; expanded model specifications for Gemma, Falcon, Med42, Meta-LlaMA-3, and Phi.
scripts/serge.env Changed LLAMA_PYTHON_VERSION from 0.2.84 to 0.2.86, reflecting an update in the Python library version.

Poem

🐰 In the meadow where models play,
New specs and formats brighten the day.
With numbers and names now aligned so tight,
The changes bring joy, oh what a sight!
A hop and a skip, the updates take flight,
Thank you, dear coders, for making it bright! 🌼✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9dd6b7c and 61d77f2.

Files ignored due to path filters (1)
  • api/src/serge/data/models.json is excluded by !**/*.json
Files selected for processing (2)
  • README.md (2 hunks)
  • scripts/serge.env (1 hunks)
Files skipped from review due to trivial changes (1)
  • scripts/serge.env
Additional comments not posted (2)
README.md (2)

55-57: Approved: Formatting changes for environment variables.

The formatting adjustments improve readability and consistency.


76-99: Approved: Additions to model specifications.

The additions of new models and variants enhance the comprehensiveness of the documentation.

However, verify the accuracy of the model names and variants to ensure correctness.

Verification successful

Verified: The model names and variants are accurately listed and used consistently across the codebase.

The model names and variants in the README.md file match those found in the api/src/serge/data/models.json file, confirming their accuracy.

  • README.md
  • api/src/serge/data/models.json
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the accuracy of the model names and variants.

# Test: Search for the model names and variants in the codebase. Expect: Correct model names and variants.
rg --type markdown -A 5 $'Gemma|Falcon|Med42|Meta-LlaMA-3|Phi'

Length of output: 1485


Script:

#!/bin/bash
# Description: Cross-reference the model names and variants in the README.md with other parts of the codebase or documentation.

# Search for model names and variants in all markdown files to ensure they are accurately listed.
rg --type markdown 'Gemma|Falcon|Med42|Meta-LlaMA-3|Phi'

Length of output: 634


Script:

#!/bin/bash
# Description: Cross-reference the model names and variants in the README.md with other parts of the codebase.

# Search for model names and variants in the entire codebase to ensure they are accurately listed and used.
rg 'Gemma|Falcon|Med42|Meta-LlaMA-3|Phi'

Length of output: 3721

@Smartappli
Copy link
Contributor Author

#1385

@gaby
Copy link
Member

gaby commented Jul 29, 2024

Blocked by abetlen/llama-cpp-python#1627

@gaby
Copy link
Member

gaby commented Aug 7, 2024

@Smartappli I'm closing this, open a new PR when changes are ready.

@gaby gaby closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants