Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled requirements aggregation for Serenity/JS #3364

Merged
merged 20 commits into from
Jan 5, 2024
Merged

Enabled requirements aggregation for Serenity/JS #3364

merged 20 commits into from
Jan 5, 2024

Conversation

jan-molak
Copy link
Member

@jan-molak jan-molak commented Dec 28, 2023 •
edited
Loading

Enables serenity-js/serenity-js#2103

Outstanding tasks:

  • Make Requirement name use pathElement segment name rather than the "human-readable" name so that the old JUnit-specific behaviour remains the same (see failing build)
  • Add a test for RequirementAncestry to ensure no future regressions in setting the parent to null instead of an empty string
  • Re-enable parallel stream processing in AggregateRequirementsService once I understand why it causes issues with merging the requirements and fix thread safety issues
  • Find a common place for JAVASCRIPT_SPEC_FILE_EXTENSION_PATTERN used in both FileSystemRequirementsTagProvider and DefaultCapabilityTypes

@jan-molak jan-molak marked this pull request as draft December 28, 2023 18:46
@jan-molak jan-molak mentioned this pull request Dec 28, 2023
Merged
13 tasks
@jan-molak jan-molak marked this pull request as ready for review December 30, 2023 23:14
@jan-molak
Corrected RequirementAncestry so that top-level requirements are comp…
929bb5a 
…atible with how TestOutcomesTagProvider generates them and so that their equals comparison works
@jan-molak
Corrected ReportNameProvider so that links to requirement summaries a…
71bf9c8 
…re compatible with those generated for requirements tags
@jan-molak
Theme, capability and feature-level reports show up correctly
37a3906
@jan-molak
Disable parallel processing in AggregateRequirementsService as it has…
0a26201 
… some bug that prevents requirements from being correctly merged
@jan-molak
Derive the name of the requirement from pathElement instead of the hu…
04a5f70 
…man-readable name as the display name is already human-readable
@jan-molak
Added missing tests to prevent future regressions in RequirementAnces…
8013da1 
…tryTest
@jan-molak
Use the human-readable name as displayName for requirements read from…
84e1349 
… the file system
@jan-molak
Updated tests to correctly assert on displayName or name
8978ef5
@jan-molak
Check both the name and the displayName of the requirement
a345254
@jan-molak
Fixed thread safety issues and enabled parallel requirement processing
6286a1e
@jan-molak
Introduced SpecFileFilters to reduce code duplication
5f7a4fc
@jan-molak
Copy link
Member Author

@wakaleo - this is now ready for your review 🚀

@wakaleo wakaleo merged commit 5bebe8e into main Jan 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-molak @wakaleo