Fixed potential issue with screenshots

serenity-bdd · Jan 10, 2024 · 9a5646e · 9a5646e
1 parent 98cccfd
commit 9a5646e
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/serenity-core/src/main/java/net/thucydides/core/steps/BaseStepListener.java b/serenity-core/src/main/java/net/thucydides/core/steps/BaseStepListener.java
@@ -1066,8 +1066,10 @@ private void takeEndOfStepScreenshotForRecording(final TestResult result, List<S
     }
 
     private void takeEndOfStepScreenshotForPlayback(final TestResult result, List<ScreenshotAndHtmlSource> screenshots) {
-        if ((screenshots != null && screenshots.size() > 0) && shouldTakeEndOfStepScreenshotFor(result)) {
+        if ((screenshots != null && !screenshots.isEmpty())) {
             allScreenshots.addAll(screenshots);
+        }
+        if ((screenshots != null && !screenshots.isEmpty()) && shouldTakeEndOfStepScreenshotFor(result)) {
             takePlayback(MANDATORY_SCREENSHOT, result, screenshots);
             usedScreenshots.addAll(screenshots);
         }