MSRV (1.56) and edition (2021) bump #2901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first cargo version that actually enforces the rust-version field in Cargo.toml
|
Does it means that you may merge PRs of which impact you are not sure, like #2811? |
|
No, this is not a breaking change nor a major version bump. This is a minor version bump, which is not allowed to break things, but only to signal that there is more change happening than in a usual patch release. Edit: not a minor bump anymore |
|
#2811 just doesn't break anything (all execution paths are covered by tests), so I ask. |
oli-obk
force-pushed
the
msrv-and-edition-bump
branch
from
b6bd601 to
c53bd64
Compare
dtolnay
reviewed
Mar 9, 2025
| @@ -18,38 +18,17 @@ fn main() { | |||
| println!("cargo:rustc-check-cfg=cfg(no_core_error)"); | |||
| println!("cargo:rustc-check-cfg=cfg(no_core_net)"); | |||
| println!("cargo:rustc-check-cfg=cfg(no_core_num_saturating)"); | |||
| println!("cargo:rustc-check-cfg=cfg(no_core_try_from)"); | |||
| println!("cargo:rustc-check-cfg=cfg(no_diagnostic_namespace)"); | |||
| println!("cargo:rustc-check-cfg=cfg(no_float_copysign)"); | |||
There was a problem hiding this comment.
Suggested change
| println!("cargo:rustc-check-cfg=cfg(no_float_copysign)"); |
dtolnay
force-pushed
the
msrv-and-edition-bump
branch
2 times, most recently
from
d0c0c38 to
8b0e95b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been 3 years (the 1.56 release) since rust-version was actually checked in Cargo.toml. So let's upgrade:
Then we can subsequently, once enough time has passed, release more serde versions that bump rust-version. I do not believe we'd inconvenience anyone, as either they are not updating their dependencies anyway (and almost everyone is bumping MSRV knowingly or unknowingly). While there are LTS systems (like debian and such) that use 5 years (or even more in some cases), these realistically can't update their dependencies without manual cherry picking anyway.
The reason I'm bringing this up now is we're optimistic that const-trait support will land this year. While I don't plan on moving serde to be usable in const contexts in any short timeframe, I want to slowly move us up so that we can make it usable in const contexts in the next 3 years.