Refactor, better error logging

seratch · May 22, 2024 · 11a88ce · 11a88ce
1 parent 88f4ed7
commit 11a88ce
Show file tree

Hide file tree

Showing 3 changed files with 130 additions and 212 deletions.
diff --git a/app/bolt_listeners.py b/app/bolt_listeners.py
@@ -593,7 +593,7 @@ def prepare_and_share_thread_summary(
             view=build_summarize_timeout_error_modal(),
         )
     except Exception as e:
-        logger.error(f"Failed to share a thread summary: {e}")
+        logger.exception(f"Failed to share a thread summary: {e}")
         client.views_update(
             view_id=payload["id"],
             view=build_summarize_error_modal(e),
@@ -709,7 +709,7 @@ def send_proofreading_result_in_dm(
                 ),
             )
     except Exception as e:
-        logger.error(f"Failed to send a DM: {e}")
+        logger.exception(f"Failed to send a DM: {e}")
 
 
 #
@@ -760,7 +760,7 @@ def display_chat_from_scratch_result(
             view=build_from_scratch_timeout_modal(text),
         )
     except Exception as e:
-        logger.error(f"Failed to share a thread summary: {e}")
+        logger.exception(f"Failed to share a thread summary: {e}")
         client.views_update(
             view_id=payload["id"],
             view=build_from_scratch_error_modal(text=text, e=e),

diff --git a/app/slack_ops.py b/app/slack_ops.py
@@ -55,7 +55,8 @@ def build_thread_replies_as_combined_text(
             if user == context.bot_user_id:  # Skip replies by this app
                 continue
             if user is None:
-                user = client.bots_info(bot=reply.get("bot_id"))["bot"]["user_id"]
+                bot_response = client.bots_info(bot=reply.get("bot_id"))
+                user = bot_response.get("bot", {}).get("user_id")
                 if user is None or user == context.bot_user_id:
                     continue
             text = slack_to_markdown("".join(reply["text"].splitlines()))