Skip to content

Mode #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 8, 2025
Merged

Mode #130

merged 13 commits into from
Jun 8, 2025

Conversation

sepandhaghighi
Copy link
Owner

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • --mode argument added

Any other comments?

@sepandhaghighi sepandhaghighi self-assigned this Jun 6, 2025
@sepandhaghighi sepandhaghighi added the enhancement New feature or request label Jun 6, 2025
@sepandhaghighi sepandhaghighi added this to the mycoffee v1.9 milestone Jun 6, 2025
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 94.42%. Comparing base (71f19d0) to head (019f714).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
mycoffee/functions.py 48.48% 15 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##               dev     #130      +/-   ##
===========================================
- Coverage   100.00%   94.42%   -5.58%     
===========================================
  Files            2        2              
  Lines          274      305      +31     
  Branches        59       64       +5     
===========================================
+ Hits           274      288      +14     
- Misses           0       15      +15     
- Partials         0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sepandhaghighi sepandhaghighi marked this pull request as ready for review June 6, 2025 15:11
Copy link
Collaborator

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, can we also have tests for coffee-to-water case? It's never tested and caused a decrease in coverage.

@sepandhaghighi
Copy link
Owner Author

This looks good, can we also have tests for coffee-to-water case? It's never tested and caused a decrease in coverage.

I will add these tests in a separate pull request.

@sadrasabouri sadrasabouri merged commit 27f47d6 into dev Jun 8, 2025
22 of 25 checks passed
@sadrasabouri sadrasabouri deleted the mode branch June 8, 2025 00:38
This was referenced Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants