[tda] Critical Experiences - switch to 24 hour cycle #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Bundle ReportBundle size has no change ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #668 +/- ##
=======================================
Coverage 34.13% 34.13%
=======================================
Files 37 37
Lines 920 920
Branches 111 111
=======================================
Hits 314 314
Misses 589 589
Partials 17 17
|
gid-sentry
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Curious on why the change to // rather than %
Wouldn't this make the probabilities that come up look less random?
| Hour | now.hour // 4 | now.hour % 4 | Same? |
|---|---|---|---|
| 0 | 0 | 0 | Yes |
| 1 | 0 | 1 | No |
| 2 | 0 | 2 | No |
| 3 | 0 | 3 | No |
| 4 | 1 | 0 | No |
| 5 | 1 | 1 | No |
| 6 | 1 | 2 | No |
| 7 | 1 | 3 | No |
| 8 | 2 | 0 | No |
| 9 | 2 | 1 | No |
| 10 | 2 | 2 | No |
| 11 | 2 | 3 | No |
| 12 | 3 | 0 | No |
| 13 | 3 | 1 | No |
| 14 | 3 | 2 | No |
| 15 | 3 | 3 | No |
| 16 | 4 | 0 | No |
| 17 | 4 | 1 | No |
| 18 | 4 | 2 | No |
| 19 | 4 | 3 | No |
| 20 | 5 | 0 | No |
| 21 | 5 | 1 | No |
| 22 | 5 | 2 | No |
| 23 | 5 | 3 | No |
Though % 4 will not come up to 5 by nature. It would be more cyclical though, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make graphs a little smoother
If this is not enough we can switch to 6-day cycle (or 14/30-day to match what SE will often have as time interval during demos)
Eventually we want this to be on a 6 week cycle to match releases (can now be overlayed in dashboards)