Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react, rails] rollback some unnecessary changes in autofix-generated PR #655 #656

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

realkosty
Copy link
Collaborator

this introduced a few unwanted changes in addition to the fix #655

@realkosty realkosty requested a review from ndmanvar as a code owner January 7, 2025 23:09
@realkosty realkosty merged commit d27844a into master Jan 7, 2025
8 checks passed
@realkosty realkosty deleted the rails-fix-autofix-2 branch January 7, 2025 23:09
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.13%. Comparing base (d6c1a96) to head (f758df9).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #656   +/-   ##
=======================================
  Coverage   34.12%   34.13%           
=======================================
  Files          37       37           
  Lines         923      920    -3     
  Branches      114      111    -3     
=======================================
- Hits          315      314    -1     
+ Misses        590      589    -1     
+ Partials       18       17    -1     
Flag Coverage Δ
api 6.59% <ø> (ø)
frontend 54.75% <100.00%> (+0.12%) ⬆️
Components Coverage Δ
checkout_module 6.59% <ø> (ø)
product_component 56.41% <100.00%> (+0.21%) ⬆️
Files with missing lines Coverage Δ
react/src/components/Products.jsx 89.55% <100.00%> (+2.40%) ⬆️

Copy link

codecov bot commented Jan 7, 2025

Bundle Report

Changes will increase total bundle size by 1.42MB (100.0%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
empower-react-app-array-push 1.42MB 1.42MB (100%) ⬆️⚠️

Copy link

sentry-io bot commented Jan 7, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ **NoMethodError: private method select' called for "#<Reviews::ActiveRecord_Relation:0x00003ebc647c33f0>":String ...** Api::V1::ProductsController#index` View Issue
  • ‼️ **NameError: undefined local variable or method prod_slow' for #<Api::V1::ProductsController:0x00000000006cc0...** Api::V1::ProductsController#index` View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant