Finish App Router Migration #615

lukemun · 2024-10-30T21:00:38Z

Migrate product page to app router
Refactor router to use dynamic app router
Refactor Product Card to clicking to stop click bubbling
Added new endpoint to query by product id

* * Create app router directory structure * Added pages and root layout * Temp made all components client as 1st migration step * Renamed conflicting pages from pages router to *2 Ran locally and checked all pages load. migrate all linked pages to app router * Create a SC route for products (#602) * Uploaded hardware db to vercel postgres * Created producs-sc page with SC Co-authored-by: Luke Munro <[email protected]> * added vercel tracing target * added vercel tracing target * updated sentry import to nextjs * removed withProfiler from about page * Reconfigure layout (#606) * Migrate layout to server * fix a bunch of crap (#607) * upgrade to next 15 * commented out session storage * commented out crasher * Moved some files and implemented naming conventions * moved some css around to fix styling * more refactor * accidently removed dynamic export * trying to disable vercel cache --------- Co-authored-by: Luke Munro <[email protected]> Co-authored-by: Luca Forstner <[email protected]> Co-authored-by: Aidan Landen <[email protected]> --------- Co-authored-by: Luke Munro <[email protected]> Co-authored-by: Aidan Landen <[email protected]> Co-authored-by: Luca Forstner <[email protected]> Co-authored-by: Aidan Landen <[email protected]>

vercel · 2024-10-30T21:00:42Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
empower	⬜️ Ignored (Inspect)	Visit Preview		Nov 11, 2024 5:46pm

next/src/pages/product2.jsx

lukemun · 2024-10-30T21:03:47Z

Accidentally amended instead of creating a new commit :/

next/src/app/product/page.jsx

codecov · 2024-10-30T21:09:39Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.21%. Comparing base (89d9e8f) to head (6e332f6).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #615      +/-   ##
==========================================
- Coverage   36.30%   36.21%   -0.09%     
==========================================
  Files          37       37              
  Lines         865      867       +2     
  Branches      109      111       +2     
==========================================
  Hits          314      314              
- Misses        532      536       +4     
+ Partials       19       17       -2

Flag	Coverage Δ
api	`7.62% <ø> (ø)`
frontend	`54.75% <ø> (-0.21%)`	⬇️

Components	Coverage Δ
checkout_module	`7.62% <ø> (ø)`
product_component	`56.41% <ø> (-0.37%)`	⬇️

see 2 files with indirect coverage changes

next/src/app/product/page.jsx

- Reorganize files - Call the flask backend from server side to show external spans - Remove unused code

- Refactor directory structure to next js standards - Add json.config for navigation - Created server component for checkout with client form that accepts a server action - Configured backend checkout to always throw out of inventory error

sentry-io · 2024-11-11T19:16:21Z

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️ Error: Not enough inventory for product incomplete-app-router-transaction View Issue

_{Did you find this useful? React with a 👍 or 👎}

* Migrate to App Router (#600) * * Create app router directory structure * Added pages and root layout * Temp made all components client as 1st migration step * Renamed conflicting pages from pages router to *2 Ran locally and checked all pages load. migrate all linked pages to app router * Create a SC route for products (#602) * Uploaded hardware db to vercel postgres * Created producs-sc page with SC Co-authored-by: Luke Munro <[email protected]> * added vercel tracing target * added vercel tracing target * updated sentry import to nextjs * removed withProfiler from about page * Reconfigure layout (#606) * Migrate layout to server * fix a bunch of crap (#607) * upgrade to next 15 * commented out session storage * commented out crasher * Moved some files and implemented naming conventions * moved some css around to fix styling * more refactor * accidently removed dynamic export * trying to disable vercel cache --------- Co-authored-by: Luke Munro <[email protected]> Co-authored-by: Luca Forstner <[email protected]> Co-authored-by: Aidan Landen <[email protected]> --------- Co-authored-by: Luke Munro <[email protected]> Co-authored-by: Aidan Landen <[email protected]> Co-authored-by: Luca Forstner <[email protected]> Co-authored-by: Aidan Landen <[email protected]> * Migrate about to app router - Reorganize files - Call the flask backend from server side to show external spans - Remove unused code * Migrate checkout flow to server actions (#617) - Refactor directory structure to next js standards - Add json.config for navigation - Created server component for checkout with client form that accepts a server action - Configured backend checkout to always throw out of inventory error * fixed loader * added logging statement for test * testing sentry sdk * testing sentry sdk * ugraded sdk version * added server action instrumentation --------- Co-authored-by: Luke Munro <[email protected]> Co-authored-by: Aidan Landen <[email protected]> Co-authored-by: Luca Forstner <[email protected]> Co-authored-by: Aidan Landen <[email protected]> Co-authored-by: Aidan Landen <[email protected]>

lukemun requested a review from realkosty as a code owner October 30, 2024 21:00

github-advanced-security bot found potential problems Oct 30, 2024

View reviewed changes

next/src/pages/product2.jsx Fixed Show resolved Hide resolved

next/src/pages/product2.jsx Fixed Show fixed Hide fixed

Merge branch 'master' into finish-migrating-app-router

91fc877

github-advanced-security bot found potential problems Oct 30, 2024

View reviewed changes

next/src/app/product/page.jsx Fixed Show fixed Hide fixed

next/src/app/product/page.jsx Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Oct 31, 2024

View reviewed changes

next/src/app/product/page.jsx Fixed Show fixed Hide fixed

vercel bot had a problem deploying to Preview November 1, 2024 15:23 Failure

lukemun force-pushed the finish-migrating-app-router branch from 3d181c9 to c75c064 Compare November 1, 2024 15:27

vercel bot had a problem deploying to Preview November 1, 2024 15:32 Failure

lukemun force-pushed the finish-migrating-app-router branch from c75c064 to b4aa2a9 Compare November 1, 2024 15:43

vercel bot had a problem deploying to Preview November 1, 2024 15:45 Failure

lukemun force-pushed the finish-migrating-app-router branch from b4aa2a9 to 8191dfb Compare November 1, 2024 15:46

vercel bot had a problem deploying to Preview November 1, 2024 16:10 Failure

Migrate about to app router

25d7e04

- Reorganize files - Call the flask backend from server side to show external spans - Remove unused code

lukemun force-pushed the finish-migrating-app-router branch from 8191dfb to 25d7e04 Compare November 1, 2024 16:41

vercel bot deployed to Preview November 1, 2024 16:43 View deployment

Migrate checkout flow to server actions (#617)

9e8944a

- Refactor directory structure to next js standards - Add json.config for navigation - Created server component for checkout with client form that accepts a server action - Configured backend checkout to always throw out of inventory error

vercel bot deployed to Preview November 1, 2024 19:39 View deployment

fixed loader

2259cd6

vercel bot deployed to Preview November 4, 2024 21:21 View deployment

added logging statement for test

829274f

vercel bot deployed to Preview November 5, 2024 23:41 View deployment

testing sentry sdk

9e7a392

vercel bot deployed to Preview November 6, 2024 00:11 View deployment

testing sentry sdk

9d3fccd

vercel bot deployed to Preview November 6, 2024 00:15 View deployment

ugraded sdk version

9c4669c

vercel bot deployed to Preview November 8, 2024 01:49 View deployment

added server action instrumentation

d10c023

vercel bot deployed to Preview November 8, 2024 02:03 View deployment

landenai self-requested a review November 11, 2024 17:46

Merge branch 'master' into finish-migrating-app-router

6e332f6

landenai approved these changes Nov 11, 2024

View reviewed changes

landenai merged commit 4082b48 into master Nov 11, 2024
18 of 19 checks passed

landenai deleted the finish-migrating-app-router branch November 11, 2024 17:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Finish App Router Migration #615

Finish App Router Migration #615

lukemun commented Oct 30, 2024

vercel bot commented Oct 30, 2024 •

edited

Loading

lukemun commented Oct 30, 2024

codecov bot commented Oct 30, 2024 •

edited

Loading

sentry-io bot commented Nov 11, 2024

Finish App Router Migration #615

Finish App Router Migration #615

Conversation

lukemun commented Oct 30, 2024

vercel bot commented Oct 30, 2024 • edited Loading

lukemun commented Oct 30, 2024

codecov bot commented Oct 30, 2024 • edited Loading

Codecov Report

sentry-io bot commented Nov 11, 2024

Suspect Issues

vercel bot commented Oct 30, 2024 •

edited

Loading

codecov bot commented Oct 30, 2024 •

edited

Loading