Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react] fix Dockerfile for mock data - DRAFT #426

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[react] fix Dockerfile for mock data - DRAFT #426

wants to merge 4 commits into from

Conversation

realkosty
Copy link
Collaborator

@realkosty realkosty commented Mar 19, 2024 •
edited
Loading

This was supposed to fix mock-data check broken when upgrading Node 16 -> 18 earlier

Doesn't seem to be working...

I suspect tempate-izing config-overrides.js is the issue as mock-data doesn't run deploy.sh that processes templates.

Screenshot 2024-03-19 at 4 51 14 PM

Base automatically changed from react-fix-se-grouping to master March 20, 2024 00:10
@realkosty realkosty changed the title [react] fix Dockerfile for mock data [react] fix Dockerfile for mock data - DRAFT Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile-sentry asottile-sentry Awaiting requested review from asottile-sentry

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@realkosty