Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov comments added on PR opens/changes #414

Merged
merged 49 commits into from
Apr 12, 2024
Merged

Conversation

cstavitsky
Copy link
Contributor

@cstavitsky cstavitsky commented Mar 6, 2024

This PR

  • When pull requests are opened/re-opened or new commits are pushed in Empower, a Codecov report will be added as a PR comment.

Evidence

See the Codecov PR comment!

What's next

@cstavitsky cstavitsky force-pushed the codecov_runs_on_PR branch from 2401878 to 97bdb3b Compare March 6, 2024 20:24
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 2.07%. Comparing base (61bc9fa) to head (ce85abd).

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #414      +/-   ##
=========================================
+ Coverage    1.95%   2.07%   +0.11%     
=========================================
  Files          37      37              
  Lines         819     821       +2     
  Branches      100     100              
=========================================
+ Hits           16      17       +1     
- Misses        778     779       +1     
  Partials       25      25              
Flag Coverage Δ
flask 4.84% <50.00%> (?)
react 0.20% <ø> (?)
Files Coverage Δ
flask/src/utils.py 44.82% <50.00%> (+0.38%) ⬆️

add missing 'runs-on' field

fix node error

set correct node version earlier in job flow

attempt parity w/existing gh action yml

pip install package that gh actions flow isn't finding
@cstavitsky cstavitsky force-pushed the codecov_runs_on_PR branch from 6ab4bc9 to 385ef91 Compare March 6, 2024 20:54
@cstavitsky cstavitsky changed the title First attempt to get codecov running on PR open/change Codecov comments added on PR opens/changes Mar 6, 2024
@cstavitsky cstavitsky requested a review from realkosty March 6, 2024 21:00
@cstavitsky
Copy link
Contributor Author

Demoting to draft - noticed some stuff I think should be different 😳

@cstavitsky cstavitsky marked this pull request as draft March 6, 2024 23:09
@cstavitsky cstavitsky marked this pull request as ready for review April 12, 2024 18:17
@cstavitsky cstavitsky requested a review from a team as a code owner April 12, 2024 18:17
@cstavitsky cstavitsky requested a review from realkosty April 12, 2024 18:24
Copy link
Collaborator

@realkosty realkosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

What's next
...
Add status checks (quality gates)

Looks like checks already implemented, no?
Screenshot 2024-04-12 at 2 38 08 PM

@cstavitsky
Copy link
Contributor Author

Oh ya, forgot we have status checks already, leftover from when I started the ticket and forgot to scroll down 😅

@cstavitsky cstavitsky merged commit a77428a into master Apr 12, 2024
10 of 11 checks passed
@cstavitsky cstavitsky deleted the codecov_runs_on_PR branch April 12, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants