Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm -> yarn #413

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

sdzhong
Copy link
Contributor

@sdzhong sdzhong commented Mar 5, 2024

Fixes #412

@sdzhong sdzhong linked an issue Mar 5, 2024 that may be closed by this pull request
@sdzhong
Copy link
Contributor Author

sdzhong commented Mar 5, 2024

Steps taken which created Replay User Click breadcrumbs:

  1. Install volta >curl https://get.volta.sh | bash
  2. Validate volta is installed with >volta -v
  3. Update to files react/build.sh and react/package.json as per commit
  4. /react>rm -rf package-lock.json node_modules && yarn install
  5. /empower>./deploy.sh --env=local react

@sdzhong
Copy link
Contributor Author

sdzhong commented Mar 5, 2024

User Click breadcrumbs are now appearing in the Replay
image

react/build.sh Outdated Show resolved Hide resolved
react/package.json Show resolved Hide resolved
@cstavitsky
Copy link
Contributor

@sdzhong @realkosty was browsing open PRs, is this in need of a re-review (once merge conflicts are fixed)?

@realkosty
Copy link
Collaborator

@sdzhong @realkosty was browsing open PRs, is this in need of a re-review (once merge conflicts are fixed)?

We just upgraded npm to 10. Let's test if this is still an issue.
@sdzhong if possible lets avoid as this will likely break mock-data and require changes there too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[react] Click Breadcrumbs missing in Replays
3 participants