[mini-relay] ignore unclassifiable metric_meta envelopes as well #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile-sentry
changed the title
realkosty
approved these changes
Feb 12, 2024
| def is_unclassifiable(self) -> bool: | ||
| return all( | ||
| item.header_type in { | ||
| 'session', 'sessions', |
There was a problem hiding this comment.
Having a crash-free-rate is not a critical requirement but nice to have in the long run.
I wonder if we can simulate it without capturing real sessions... after all in demo org it's OK if it doesn't match errors.
There was a problem hiding this comment.
yeah I think so -- or at least we can fabricate sessions to match it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should allow us to re-enable the check here
ideally tags would be forwarded along with
metric_metaandstatsdand then these could get classified 🤔