discard ui.action.click transactions #383
Conversation
| beforeSendTransaction(event) { | ||
| // ui.action.click transactions are showing up in the demo | ||
| // which is undesirable | ||
| if (event?.contexts?.trace?.op === 'ui.action.click') { |
There was a problem hiding this comment.
Is this too general? Is it a bad thing if we filter out ALL ui.action.click transactions?
There was a problem hiding this comment.
@cstavitsky I believe we since un-did the Experiment for transactions from UI clicks but here's my take on this.
I'm a believer that if no one is specifically using ui.action.click transactions, then no, it's not a problem to remove them. When we adopt Beta's and Experiments for the sake of padding our demo data with more data, without a clear defined benefit, then it's opening us up to risk of interference in unforeseen ways.
|
@cstavitsky if we do this we will be left with a tiny number of navigate events and it may affect measurements/graphs. See my last message in slack. |
|
The Lines 106 to 107 in d509baf |
What Is It
Removes
ui.action.clicktransactions to avoid confusion during demosContext
Will C (Wed Jan 24 2024)
Can anyone fill me on on what the ui.action.click for /products is about?
or link me to a PullRequest?
I opened it, it appears like a pageload txn, it has spans you’d find in a pageload
Will C
The TPM indicates it’s probably being done via TDA, is that the case?
Not asking for either of the /products /products to be removed.
Just looking to be aware of any potential differences or plans regarding demo’s or the architecture of our app.
Kosty M
weird
Chris S
Probably this? getsentry/sentry-javascript#5750
Edit: nvm, looks like it is still open: getsentry/sentry-javascript#6941 (edited)
🥔
1
Kosty M
interesting how navigation is still there but is a tiny fraction by TPM/#of users
and it’s not coming from an old SDK: https://demo.sentry.io/discover/homepage/?display=default&field=sdk.version&field=tr[…]n%3A%2Fproducts&sort=-sdk.version&statsPeriod=24h&topEvents=5