Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react] automatically propagete tags (se, etc.) as headers for all fetch requests #331

Merged
merged 1 commit into from
Nov 28, 2023
Merged

[react] automatically propagete tags (se, etc.) as headers for all fetch requests #331

merged 1 commit into from
Nov 28, 2023

Conversation

realkosty
Copy link
Collaborator

Motivation

se tag which will be a requirement for "mock data" capture is missing on a bunch of Flask endpoints because it wasn't passed form frontend.

Testing

example event (staging)

@realkosty realkosty marked this pull request as ready for review November 20, 2023 18:25
@realkosty realkosty requested a review from a team as a code owner November 20, 2023 18:25
@realkosty realkosty force-pushed the se-tag branch 2 times, most recently from 64676ab to 422f976 Compare November 27, 2023 05:59
asottile-sentry
asottile-sentry approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cstavitsky
cstavitsky approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@cstavitsky cstavitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question about port but does not block approval.

Tested across several events in staging, looks fine:

react/src/index.js Show resolved Hide resolved
@realkosty realkosty merged commit 9d29e37 into master Nov 28, 2023
6 checks passed
@realkosty realkosty deleted the se-tag branch November 28, 2023 03:36
realkosty added a commit that referenced this pull request Nov 29, 2023
@realkosty
[react] fix mis-merge of PR #331
8ae5394
@realkosty realkosty mentioned this pull request Nov 29, 2023
Merged
@realkosty
Copy link
Collaborator Author

@cstavitsky #354 🙏

realkosty added a commit that referenced this pull request Nov 29, 2023
@realkosty
[react] fix mis-merge of PR #331
99e0e1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile-sentry asottile-sentry asottile-sentry approved these changes

@cstavitsky cstavitsky cstavitsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@realkosty @cstavitsky @asottile-sentry